fix: Apply border-radius to search scrollbar#409
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
|
without an border-radius it looks really unsexy :( |
I'll try other approaches, maybe this will work: https://stackoverflow.com/questions/16676166/apply-border-radius-to-scrollbars-with-css |
MoritzWeber0
force-pushed
the
fix/border-radius-search
branch
from
b7165c9 to
0308ccb
Compare
MoritzWeber0
changed the title
|
Now it looks better :) 
|
|
On windows there is an "scroll-down"-Button at the end of the scrollbar. Could it be cut of by the corner? I have no windows device so i can't check 🙃 I think it is okay to merge it now and check afterwards :) if there is an issue with the current implementation, we could add space with the borders under the scroll-area |
|
In #409, the definition of the max-height was moved to another class, this PR reflects this for the mobile max-height, otherwise it doesn't overwrite the value. Also remove an unnecessary hard-coded positioning of the search drawer, which led to gaps between drawer and search bar on some devices.
2 participants
This PR fixes the missing border radius at the bottom right border.